External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-04-01 20:05:19 +00:00
Code

qemu: Bring if() outside from loop in virDomainFSInfoFormat()

Browse Source 
After previous commit, the freeing of @info_ret inside of
virDomainFSInfoFormat() looks like this:

  for () {
    if (info_ret)
      virDomainFSInfoFree(info_ret[i]);
  }

It is needless to compare @info_ret against NULL in each
iteration. We can switch the order and do the comparison first
followed by the loop.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
This commit is contained in:
Michal Privoznik 2021-02-15 17:19:10 +01:00
parent 59c80e9fd0
commit 9ad1e1d897
1 changed files with 6 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
src/qemu/qemu_driver.c
View File

@ -18977,13 +18977,14 @@ virDomainFSInfoFormat(qemuAgentFSInfoPtr *agentinfo,
ret = nagentinfo;
cleanup:
for (i = 0; i < nagentinfo; i++) {
/* if there was an error, free any memory we've allocated for the
* return value */
if (info_ret)
if (info_ret) {
for (i = 0; i < nagentinfo; i++) {
/* if there was an error, free any memory we've allocated for the
* return value */
virDomainFSInfoFree(info_ret[i]);
}
g_free(info_ret);
}
g_free(info_ret);
return ret;
}