External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2024-10-05 05:45:46 +00:00
Code Issues Packages Projects Releases Wiki Activity

gendispatch: Avoid comparing signed and unsigned vars

Browse Source 
The adminDispatchConnectListServers() function is generated by
our great perl script. However, it has a tiny flaw: if
adminConnectListServers() it calls fails, the control jumps onto
cleanup label where we try to free any list of servers built so
far. However, in the loop @i is unsigned (size_t) while @nresults
is signed (int). Currently, it does no harm because of the check
for @result being non-NULL. But if that ever changes in the
future, this bug will be hard to chase.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
This commit is contained in:
Michal Privoznik 2016-03-16 10:24:38 +01:00
parent cbe289d814
commit 9b48ef9c51
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/rpc/gendispatch.pl
View File

@ -917,7 +917,7 @@ elsif ($mode eq "server") {
print " int rv = -1;\n";
if ($modern_ret_as_list) {
print " size_t i;\n";
print " ssize_t i;\n";
}
foreach my $var (@vars_list) {