External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2024-07-07 18:35:46 +00:00
Code Issues Packages Projects Releases Wiki Activity

nwfilter: address coverity findings

Browse Source 
This patch addresses the following coverity findings:

/libvirt/src/conf/nwfilter_params.c:157:
deref_parm: Directly dereferencing parameter "val".

/libvirt/src/conf/nwfilter_params.c:473:
negative_returns: Using variable "iterIndex" as an index to array "res->iter".

/libvirt/src/nwfilter/nwfilter_ebiptables_driver.c:2891:
unchecked_value: No check of the return value of "virAsprintf(&protostr, "-d 01:80:c2:00:00:00 ")".

/libvirt/src/nwfilter/nwfilter_ebiptables_driver.c:2894:
unchecked_value: No check of the return value of "virAsprintf(&protostr, "-p 0x%04x ", l3_protocols[protoidx].attr)".

/libvirt/src/nwfilter/nwfilter_ebiptables_driver.c:3590:
var_deref_op: Dereferencing null variable "inst".
This commit is contained in:
Stefan Berger 2012-04-26 16:45:36 -04:00 committed by Stefan Berger
parent 9586925bac
commit 9c1ce3dc11
2 changed files with 10 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/conf/nwfilter_params.c
View File

@ -154,6 +154,9 @@ virNWFilterVarValueGetNthValue(virNWFilterVarValuePtr val, unsigned int idx)
{
const char *res = NULL;
if (!val)
return NULL;
switch (val->valType) {
case NWFILTER_VALUE_TYPE_SIMPLE:
if (idx == 0)
@ -467,7 +470,7 @@ virNWFilterVarCombIterCreate(virNWFilterHashTablePtr hash,
res->nIter++;
break;
case VIR_NWFILTER_VAR_ACCESS_LAST:
break;
goto err_exit;
}
if (virNWFilterVarCombIterAddVariable(&res->iter[iterIndex],

8
src/nwfilter/nwfilter_ebiptables_driver.c
View File

@ -2888,10 +2888,11 @@ ebtablesCreateTmpSubChain(ebiptablesRuleInstPtr *inst,
protostr = strdup("");
break;
case L2_PROTO_STP_IDX:
virAsprintf(&protostr, "-d " NWFILTER_MAC_BGA " ");
ignore_value(virAsprintf(&protostr, "-d " NWFILTER_MAC_BGA " "));
break;
default:
virAsprintf(&protostr, "-p 0x%04x ", l3_protocols[protoidx].attr);
ignore_value(virAsprintf(&protostr, "-p 0x%04x ",
l3_protocols[protoidx].attr));
break;
}
@ -3589,6 +3590,9 @@ ebiptablesApplyNewRules(const char *ifname,
int nEbtChains = 0;
char *errmsg = NULL;
if (inst == NULL)
nruleInstances = 0;
if (!chains_in_set || !chains_out_set) {
virReportOOMError();
goto exit_free_sets;