External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2024-07-07 18:35:46 +00:00
Code Issues Packages Projects Releases Wiki Activity

nwfilter: transform logic in virNWFilterRuleInstSort to eliminate label

Browse Source 
This rewrite of a nested conditional produces the same results, but
eliminate a goto and corresponding label.

Signed-off-by: Laine Stump <laine@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
This commit is contained in:
Laine Stump 2020-06-24 22:30:38 -04:00
parent ad668b98e9
commit 9c5cd04545
1 changed files with 5 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
src/nwfilter/nwfilter_ebiptables_driver.c
View File

@ -3113,13 +3113,12 @@ virNWFilterRuleInstSort(const void *a, const void *b)
/* ensure root chain commands appear before all others since
we will need them to create the child chains */
if (root_a) {
if (root_b)
goto normal;
return -1; /* a before b */
}
if (root_b)
if (!root_b)
return -1; /* a before b */
} else if (root_b) {
return 1; /* b before a */
normal:
}
/* priorities are limited to range [-1000, 1000] */
return insta->priority - instb->priority;
}