From 9ceb3cff8582119d2f907b85655e758068770e83 Mon Sep 17 00:00:00 2001 From: Laine Stump Date: Fri, 19 Jun 2020 17:40:17 -0400 Subject: [PATCH] network: fix memory leak in networkBuildDhcpDaemonCommandLine() MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit hostsfilestr was not being freed. This will be turned into g_autofree in an upcoming patch converting a lot more of the same file to using g_auto*, but I wanted to make a separate patch for this first so the other patch is simpler to review (and to make backporting easier). The leak was introduced in commit 97a0aa246799c97d0a9ca9ecd6b4fd932ae4756c Signed-off-by: Laine Stump Reviewed-by: Ján Tomko --- src/network/bridge_driver.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/network/bridge_driver.c b/src/network/bridge_driver.c index 47d5d95678..aff1b7b1bc 100644 --- a/src/network/bridge_driver.c +++ b/src/network/bridge_driver.c @@ -1628,6 +1628,7 @@ networkBuildDhcpDaemonCommandLine(virNetworkDriverStatePtr driver, virObjectUnref(dnsmasq_caps); VIR_FREE(configfile); VIR_FREE(configstr); + VIR_FREE(hostsfilestr); VIR_FREE(leaseshelper_path); return ret; }