External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-02-02 01:45:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

qemu: domain: split out post parse default device handling

Browse Source 
Should be a no-op
This commit is contained in:
Cole Robinson 2016-01-06 20:35:36 -05:00
parent ee719cdcca
commit 9cec6239c1
1 changed files with 33 additions and 19 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

52
src/qemu/qemu_domain.c
View File

@ -1035,12 +1035,9 @@ virDomainXMLNamespace virQEMUDriverDomainXMLNamespace = {
static int static int
qemuDomainDefPostParse(virDomainDefPtr def, qemuDomainDefAddDefaultDevices(virDomainDefPtr def,
virCapsPtr caps, virQEMUCapsPtr qemuCaps)
void *opaque)
{ {
virQEMUDriverPtr driver = opaque;
virQEMUCapsPtr qemuCaps = NULL;
bool addDefaultUSB = true; bool addDefaultUSB = true;
bool addImplicitSATA = false; bool addImplicitSATA = false;
bool addPCIRoot = false; bool addPCIRoot = false;
@ -1051,20 +1048,6 @@ qemuDomainDefPostParse(virDomainDefPtr def,
bool addPanicDevice = false; bool addPanicDevice = false;
int ret = -1; int ret = -1;
if (def->os.bootloader || def->os.bootloaderArgs) {
virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s",
_("bootloader is not supported by QEMU"));
return ret;
}
/* check for emulator and create a default one if needed */
if (!def->emulator &&
!(def->emulator = virDomainDefGetDefaultEmulator(def, caps)))
return ret;
qemuCaps = virQEMUCapsCacheLookup(driver->qemuCapsCache, def->emulator);
/* Add implicit PCI root controller if the machine has one */ /* Add implicit PCI root controller if the machine has one */
switch (def->os.arch) { switch (def->os.arch) {
case VIR_ARCH_I686: case VIR_ARCH_I686:
@ -1218,6 +1201,37 @@ qemuDomainDefPostParse(virDomainDefPtr def,
} }
} }
ret = 0;
cleanup:
return ret;
}
static int
qemuDomainDefPostParse(virDomainDefPtr def,
virCapsPtr caps,
void *opaque)
{
virQEMUDriverPtr driver = opaque;
virQEMUCapsPtr qemuCaps = NULL;
int ret = -1;
if (def->os.bootloader || def->os.bootloaderArgs) {
virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s",
_("bootloader is not supported by QEMU"));
return ret;
}
/* check for emulator and create a default one if needed */
if (!def->emulator &&
!(def->emulator = virDomainDefGetDefaultEmulator(def, caps)))
return ret;
qemuCaps = virQEMUCapsCacheLookup(driver->qemuCapsCache, def->emulator);
if (qemuDomainDefAddDefaultDevices(def, qemuCaps) < 0)
goto cleanup;
ret = 0; ret = 0;
cleanup: cleanup:
virObjectUnref(qemuCaps); virObjectUnref(qemuCaps);