External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-01-23 13:05:27 +00:00
Code Issues Packages Projects Releases Wiki Activity

configure: Fix check for --with-login-shell on Windows

Browse Source 
The check is supposed to stop users from trying to compile
virt-login-shell on Windows by erroring out during the
configure phase; however, there are two flaws in it:

  * the value of "x$with_win" is compared to "yes" instead
    of "xyes" (note the "x" in the first string)

  * "test" is not being used, so the script will actually
    try to run a command called "x$with_win" instead of
    performing string comparison

This patch fixes both issues.

(cherry picked from commit ccf58bd72a426f34481787af694d6eae78b4e64e)
This commit is contained in:
Andrea Bolognani 2016-04-08 16:17:16 +02:00 committed by Cole Robinson
parent 7497777b50
commit 9d06d0f66f
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
m4/virt-login-shell.m4
View File

@ -22,7 +22,7 @@ AC_DEFUN([LIBVIRT_CHECK_LOGIN_SHELL], [
if test "x$with_login_shell" != "xno"; then
if test "x$with_win" = "xyes"; then
if "x$with_login_shell" = "yes"; then
if test "x$with_login_shell" = "xyes"; then
AC_MSG_ERROR([virt-login-shell is not supported on Windows])
else
with_login_shell=no;