External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2024-12-24 14:45:24 +00:00
Code Issues Packages Projects Releases Wiki Activity

conf: Fix error path in virNodeDevPCICapabilityParseXML

Browse Source 
If the call to virXPathNodeSet to set naddresses fails, Coverity notes
that the subsequent VIR_ALLOC_N cannot have a negative value (well it
probably wouldn't be negative per se).

Signed-off-by: John Ferlan <jferlan@redhat.com>
This commit is contained in:
John Ferlan 2016-05-05 18:41:28 -04:00
parent 70e9114e7c
commit 9d418b20ae
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/conf/node_device_conf.c
View File

@ -1305,7 +1305,10 @@ virNodeDevPCICapabilityParseXML(xmlXPathContextPtr ctxt,
data->pci_dev.physical_function) < 0) data->pci_dev.physical_function) < 0)
goto out; goto out;
} else if (STREQ(type, "virt_functions")) { } else if (STREQ(type, "virt_functions")) {
int naddresses = virXPathNodeSet("./address", ctxt, &addresses); int naddresses;
if ((naddresses = virXPathNodeSet("./address", ctxt, &addresses)) < 0)
goto out;
if (maxFuncsStr && if (maxFuncsStr &&
virStrToLong_uip(maxFuncsStr, NULL, 10, virStrToLong_uip(maxFuncsStr, NULL, 10,