External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2024-08-07 17:29:36 +00:00
Code Issues Packages Projects Releases Wiki Activity

qemuFirmwareFillDomain: Don't fill in firmware for network backed nvram

Browse Source 
Prepare for network backed nvram by refusing the reset of nvram on boot
and don't check whether it exists. We will not support filling it from a
template.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
Tested-by: Rohit Kumar <rohit.kumar3@nutanix.com>
This commit is contained in:
Peter Krempa 2022-06-03 13:22:42 +02:00
parent bca731d0f5
commit 9d8abe0480
1 changed files with 16 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
src/qemu/qemu_firmware.c
View File

@ -1371,10 +1371,22 @@ qemuFirmwareFillDomain(virQEMUDriver *driver,
def->os.loader->nvramTemplate)
return 0;
if (!reset_nvram && def->os.loader->nvram &&
virStorageSourceIsLocalStorage(def->os.loader->nvram) &&
virFileExists(def->os.loader->nvram->path))
return 0;
if (def->os.loader->nvram) {
if (!virStorageSourceIsLocalStorage(def->os.loader->nvram)) {
if (reset_nvram) {
virReportError(VIR_ERR_OPERATION_UNSUPPORTED, "%s",
_("resetting of nvram is not supported with network backed nvram"));
return -1;
}
/* we don't scrutinize whether NVRAM image accessed via network
* is present */
return 0;
}
if (!reset_nvram && virFileExists(def->os.loader->nvram->path))
return 0;
}
/* ... then we want to consult JSON FW descriptors first,
* but we don't want to fail if we haven't found a match. */