External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-01-21 20:15:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

virlog: Return void instead of int in virLogReset<Foo> methods

Browse Source 
In this particular case, reset is meant as clearing the whole list of
outputs/filters, not resetting it to a predefined default setting. Looking at
it from that perspective, returning the number of records removed doesn't help
the caller in any way (not that any of the callers would actually check for
it). Well, callers could detect an error from the number of successfully
removed records, but the only thing that can fail in virLogReset is force
closing a file descriptor in which case the error isn't propagated back to
virLogReset anyway. Conclusion: there is no practical use for having a return
type of 'int' rather than 'void' in this case.

Signed-off-by: Erik Skultety <eskultet@redhat.com>
This commit is contained in:
Erik Skultety 2016-03-30 12:25:35 +02:00
parent cd89d3451b
commit 9dbd728ada
1 changed files with 4 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
src/util/virlog.c
View File

@ -117,8 +117,8 @@ static int virLogNbOutputs;
*/
static virLogPriority virLogDefaultPriority = VIR_LOG_DEFAULT;
static int virLogResetFilters(void);
static int virLogResetOutputs(void);
static void virLogResetFilters(void);
static void virLogResetOutputs(void);
static void virLogOutputToFd(virLogSourcePtr src,
virLogPriority priority,
const char *filename,
@ -239,10 +239,8 @@ virLogSetDefaultPriority(virLogPriority priority)
* virLogResetFilters:
*
* Removes the set of logging filters defined.
*
* Returns the number of filters removed
*/
static int
static void
virLogResetFilters(void)
{
size_t i;
@ -252,7 +250,6 @@ virLogResetFilters(void)
VIR_FREE(virLogFilters);
virLogNbFilters = 0;
virLogFiltersSerial++;
return i;
}
@ -319,10 +316,8 @@ virLogDefineFilter(const char *match,
* virLogResetOutputs:
*
* Removes the set of logging output defined.
*
* Returns the number of output removed
*/
static int
static void
virLogResetOutputs(void)
{
size_t i;
@ -333,9 +328,7 @@ virLogResetOutputs(void)
VIR_FREE(virLogOutputs[i].name);
}
VIR_FREE(virLogOutputs);
i = virLogNbOutputs;
virLogNbOutputs = 0;
return i;
}