mirror of
https://gitlab.com/libvirt/libvirt.git
synced 2025-03-07 17:28:15 +00:00
Always open files in binary mode in virFDStreamOpenFileInternal
On win32, using text mode for binary files might result in short reads since ASCII character 0x1A is interpreted as EOF. Also, it could lead to problems using the seek functions because of the \r handling. Signed-off-by: Claudio Bley <cbley@av-test.de>
This commit is contained in:
parent
291edf708b
commit
9f219dca48
@ -593,7 +593,7 @@ virFDStreamOpenFileInternal(virStreamPtr st,
|
||||
VIR_DEBUG("st=%p path=%s oflags=%x offset=%llu length=%llu mode=%o",
|
||||
st, path, oflags, offset, length, mode);
|
||||
|
||||
oflags |= O_NOCTTY;
|
||||
oflags |= O_NOCTTY | O_BINARY;
|
||||
|
||||
if (oflags & O_CREAT)
|
||||
fd = open(path, oflags, mode);
|
||||
|
Loading…
x
Reference in New Issue
Block a user