External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-03-20 07:59:00 +00:00
Code

Always open files in binary mode in virFDStreamOpenFileInternal

Browse Source 
On win32, using text mode for binary files might result in short
reads since ASCII character 0x1A is interpreted as EOF. Also, it
could lead to problems using the seek functions because of the \r
handling.

Signed-off-by: Claudio Bley <cbley@av-test.de>
This commit is contained in:
Claudio Bley 2013-09-24 11:57:38 +02:00
parent 291edf708b
commit 9f219dca48
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/fdstream.c
View File

@ -593,7 +593,7 @@ virFDStreamOpenFileInternal(virStreamPtr st,
VIR_DEBUG("st=%p path=%s oflags=%x offset=%llu length=%llu mode=%o",
st, path, oflags, offset, length, mode);
oflags |= O_NOCTTY;
oflags |= O_NOCTTY | O_BINARY;
if (oflags & O_CREAT)
fd = open(path, oflags, mode);