External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2024-12-23 14:15:28 +00:00
Code Issues Packages Projects Releases Wiki Activity

qemu: Resolve Coverity REVERSE_INULL

Browse Source 
Coverity complains that checking for !domlist after setting doms = domlist
and making a deref of doms just above

It seems the call in question was intended to me made in the case that
'doms' was passed in and not when the virDomainObjListExport() call
allocated domlist and already called virConnectGetAllDomainStatsCheckACL().

Thus rather than check for !domlist - check that "doms != domlist" in
order to avoid the Coverity message.

Signed-off-by: John Ferlan <jferlan@redhat.com>
This commit is contained in:
John Ferlan 2014-09-04 10:12:13 -04:00
parent abddeb8434
commit 9f845b1115
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/qemu/qemu_driver.c
View File

@ -17402,7 +17402,7 @@ qemuConnectGetAllDomainStats(virConnectPtr conn,
if (!(dom = qemuDomObjFromDomain(doms[i])))
continue;
if (!domlist &&
if (doms != domlist &&
!virConnectGetAllDomainStatsCheckACL(conn, dom->def))
continue;