External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2024-07-11 12:25:52 +00:00
Code Issues Packages Projects Releases Wiki Activity

Remove virsh-all

Browse Source 
Since e8ac4a7 this test wastes some CPU cycles by blindly trying to
run almost every virsh command, blindly throwing away the output
and the return value and returning success if 'virsh help' successfully
returned at least one command.

Drop it completely.
This commit is contained in:
Ján Tomko 2016-06-17 19:32:24 +02:00
parent 832f160247
commit 9f95593d60
2 changed files with 0 additions and 53 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
tests/Makefile.am
View File

@ -361,7 +361,6 @@ libvirtd_test_scripts = \
libvirtd-fail \
libvirtd-pool \
virconftest.sh \
virsh-all \
virsh-cpuset \
virsh-define-dev-segfault \
virsh-int-overflow \

52
tests/virsh-all
View File

@ -1,52 +0,0 @@
#!/bin/sh
# blindly run each and every command listed by "virsh help"
# Copyright (C) 2008, 2009 Red Hat, Inc.
# This program is free software: you can redistribute it and/or modify
# it under the terms of the GNU General Public License as published by
# the Free Software Foundation, either version 2 of the License, or
# (at your option) any later version.
# This program is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
# GNU General Public License for more details.
# You should have received a copy of the GNU General Public License
# along with this program. If not, see
# <http://www.gnu.org/licenses/>.
. "$(dirname $0)/test-lib.sh"
test_expensive
fail=0
test_url=test:///default
$abs_top_builddir/tools/virsh -c $test_url help | grep -v connect > cmds || framework_failure
cmds=$(sed -n 's/^ \([^ ][^ ]*\) .*/\1/p' cmds) || framework_failure
test -n "$cmds" || framework_failure
test_intro "virsh-all"
counter=0
for i in $cmds; do
counter=`eval "expr $counter + 1"`
# For now, just run the command and ignore output
$abs_top_builddir/tools/virsh -c $test_url $i < /dev/null > /dev/null 2>&1
# Temporarily ignoring exit status
#status=$?
status=0
test_result $counter $i $status
if test "$status" = "1" ; then
fail=1
fi
done
test_final $counter $fail
(exit $fail); exit $fail