External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-01-10 14:57:42 +00:00
Code Issues Packages Projects Releases Wiki Activity

Error out on an address for isa-serial in QEMU driver.

Browse Source 
We've never formatted them on the qemu command line.

https://bugzilla.redhat.com/show_bug.cgi?id=1164053
This commit is contained in:
Ján Tomko 2015-03-04 08:58:02 +01:00
parent eab968c7d7
commit a00e5c662b
1 changed files with 11 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/qemu/qemu_command.c
View File

@ -10533,7 +10533,8 @@ qemuBuildSerialChrDeviceStr(char **deviceStr,
virDomainChrSerialTargetTypeToString(serial->targetType), virDomainChrSerialTargetTypeToString(serial->targetType),
serial->info.alias, serial->info.alias); serial->info.alias, serial->info.alias);
if (serial->targetType == VIR_DOMAIN_CHR_SERIAL_TARGET_TYPE_USB) { switch (serial->targetType) {
case VIR_DOMAIN_CHR_SERIAL_TARGET_TYPE_USB:
if (!virQEMUCapsGet(qemuCaps, QEMU_CAPS_DEVICE_USB_SERIAL)) { if (!virQEMUCapsGet(qemuCaps, QEMU_CAPS_DEVICE_USB_SERIAL)) {
virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s",
_("usb-serial is not supported in this QEMU binary")); _("usb-serial is not supported in this QEMU binary"));
@ -10549,6 +10550,15 @@ qemuBuildSerialChrDeviceStr(char **deviceStr,
if (qemuBuildDeviceAddressStr(&cmd, def, &serial->info, qemuCaps) < 0) if (qemuBuildDeviceAddressStr(&cmd, def, &serial->info, qemuCaps) < 0)
goto error; goto error;
break;
case VIR_DOMAIN_CHR_SERIAL_TARGET_TYPE_ISA:
if (serial->info.type != VIR_DOMAIN_DEVICE_ADDRESS_TYPE_NONE) {
virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s",
_("no addresses are suported for isa-serial"));
goto error;
}
break;
} }
} }