External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2024-12-22 05:35:25 +00:00
Code Issues Packages Projects Releases Wiki Activity

schema: require target path in storage pool xml

Browse Source 
Make target path mandatory for pool types that require target,
since we refuse to parse a target without a path.

https://bugzilla.redhat.com/show_bug.cgi?id=893273
This commit is contained in:
Ján Tomko 2013-05-16 15:37:14 +02:00
parent 9049d6a8c7
commit a07b88ee03
4 changed files with 17 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
docs/schemas/storagepool.rng
View File

@ -200,11 +200,9 @@
<define name='target'> <define name='target'>
<element name='target'> <element name='target'>
<optional> <element name='path'>
<element name='path'> <ref name='absFilePath'/>
<ref name='absFilePath'/> </element>
</element>
</optional>
<ref name='permissions'/> <ref name='permissions'/>
</element> </element>
</define> </define>

1
tests/Makefile.am
View File

@ -73,6 +73,7 @@ EXTRA_DIST = \
securityselinuxlabeldata \ securityselinuxlabeldata \
schematestutils.sh \ schematestutils.sh \
sexpr2xmldata \ sexpr2xmldata \
storagepoolschemadata \
storagepoolschematest \ storagepoolschematest \
storagepoolxml2xmlin \ storagepoolxml2xmlin \
storagepoolxml2xmlout \ storagepoolxml2xmlout \

12
tests/storagepoolschemadata/dir-missing-target-path-invalid.xml Normal file
View File

@ -0,0 +1,12 @@
<pool type='dir'>
<name>test</name>
<source>
</source>
<target>
<permissions>
<mode>0700</mode>
<owner>-1</owner>
<group>-1</group>
</permissions>
</target>
</pool>

2
tests/storagepoolschematest
View File

@ -4,7 +4,7 @@
. $srcdir/test-lib.sh . $srcdir/test-lib.sh
. $abs_srcdir/schematestutils.sh . $abs_srcdir/schematestutils.sh
DIRS="storagepoolxml2xmlin storagepoolxml2xmlout" DIRS="storagepoolxml2xmlin storagepoolxml2xmlout storagepoolschemadata"
SCHEMA="storagepool.rng" SCHEMA="storagepool.rng"
check_schema "$DIRS" "$SCHEMA" check_schema "$DIRS" "$SCHEMA"