External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-01-31 00:45:18 +00:00
Code Issues Packages Projects Releases Wiki Activity

tests: virjson: Reuse VIR_TEST_VERBOSE in testJSONCopy

Browse Source 
Use VIR_TEST_VERBOSE instead of calling virTestGetVerbose and
conditionally fprintf. Additionally remove redundant setting of 'ret' to
-1.
This commit is contained in:
Peter Krempa 2017-07-11 14:40:05 +02:00
parent ffdf532328
commit a1ac4c880b
1 changed files with 6 additions and 20 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
tests/virjsontest.c
View File

@ -240,40 +240,31 @@ testJSONCopy(const void *data)
json = virJSONValueFromString(info->doc);
if (!json) {
if (virTestGetVerbose())
fprintf(stderr, "Failed to parse %s\n", info->doc);
ret = -1;
VIR_TEST_VERBOSE("Failed to parse %s\n", info->doc);
goto cleanup;
}
jsonCopy = virJSONValueCopy(json);
if (!jsonCopy) {
if (virTestGetVerbose())
fprintf(stderr, "Failed to copy JSON data\n");
ret = -1;
VIR_TEST_VERBOSE("Failed to copy JSON data\n");
goto cleanup;
}
result = virJSONValueToString(json, false);
if (!result) {
if (virTestGetVerbose())
fprintf(stderr, "Failed to format original JSON data\n");
ret = -1;
VIR_TEST_VERBOSE("Failed to format original JSON data\n");
goto cleanup;
}
resultCopy = virJSONValueToString(json, false);
if (!resultCopy) {
if (virTestGetVerbose())
fprintf(stderr, "Failed to format copied JSON data\n");
ret = -1;
VIR_TEST_VERBOSE("Failed to format copied JSON data\n");
goto cleanup;
}
if (STRNEQ(result, resultCopy)) {
if (virTestGetVerbose())
virTestDifference(stderr, result, resultCopy);
ret = -1;
goto cleanup;
}
@ -282,24 +273,19 @@ testJSONCopy(const void *data)
result = virJSONValueToString(json, true);
if (!result) {
if (virTestGetVerbose())
fprintf(stderr, "Failed to format original JSON data\n");
ret = -1;
VIR_TEST_VERBOSE("Failed to format original JSON data\n");
goto cleanup;
}
resultCopy = virJSONValueToString(json, true);
if (!resultCopy) {
if (virTestGetVerbose())
fprintf(stderr, "Failed to format copied JSON data\n");
ret = -1;
VIR_TEST_VERBOSE("Failed to format copied JSON data\n");
goto cleanup;
}
if (STRNEQ(result, resultCopy)) {
if (virTestGetVerbose())
virTestDifference(stderr, result, resultCopy);
ret = -1;
goto cleanup;
}