External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-02-22 03:12:22 +00:00
Code Issues Packages Projects Releases Wiki Activity

conf: Drop unused parameter

Browse Source 
Drop unused parameter from virDomainNetReleaseActualDevice method.

Signed-off-by: Praveen K Paladugu <prapal@linux.microsoft.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
This commit is contained in:
Praveen K Paladugu 2024-01-16 15:25:39 -06:00 committed by Michal Privoznik
parent 5e95cedbb2
commit a22d7fde17
8 changed files with 13 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/conf/domain_conf.c
View File

@ -30268,7 +30268,6 @@ virDomainNetNotifyActualDevice(virConnectPtr conn,
int
virDomainNetReleaseActualDevice(virConnectPtr conn,
virDomainDef *dom G_GNUC_UNUSED,
virDomainNetDef *iface)
{
virNetworkPtr net = NULL;

3
src/conf/domain_conf.h
View File

@ -4407,9 +4407,8 @@ virDomainNetNotifyActualDevice(virConnectPtr conn,
int
virDomainNetReleaseActualDevice(virConnectPtr conn,
virDomainDef *dom,
virDomainNetDef *iface)
ATTRIBUTE_NONNULL(1) ATTRIBUTE_NONNULL(2);
ATTRIBUTE_NONNULL(1);
int
virDomainNetBandwidthUpdate(virDomainNetDef *iface,

2
src/libxl/libxl_domain.c
View File

@ -749,7 +749,7 @@ libxlNetworkUnwindDevices(virDomainDef *def)
g_autoptr(virConnect) conn = virGetConnectNetwork();
if (conn)
virDomainNetReleaseActualDevice(conn, def, net);
virDomainNetReleaseActualDevice(conn, net);
else
VIR_WARN("Unable to release network device '%s'", NULLSTR(net->ifname));
}

4
src/libxl/libxl_driver.c
View File

@ -3440,7 +3440,7 @@ libxlDomainAttachNetDevice(libxlDriverPrivate *driver,
} else {
virDomainNetRemoveHostdev(vm->def, net);
if (net->type == VIR_DOMAIN_NET_TYPE_NETWORK && conn)
virDomainNetReleaseActualDevice(conn, vm->def, net);
virDomainNetReleaseActualDevice(conn, net);
}
virObjectUnref(cfg);
virErrorRestore(&save_err);
@ -3911,7 +3911,7 @@ libxlDomainDetachNetDevice(libxlDriverPrivate *driver,
if (detach->type == VIR_DOMAIN_NET_TYPE_NETWORK) {
g_autoptr(virConnect) conn = virGetConnectNetwork();
if (conn)
virDomainNetReleaseActualDevice(conn, vm->def, detach);
virDomainNetReleaseActualDevice(conn, detach);
else
VIR_WARN("Unable to release network device '%s'", NULLSTR(detach->ifname));
}

2
src/lxc/lxc_driver.c
View File

@ -4110,7 +4110,7 @@ lxcDomainDetachDeviceNetLive(virDomainObj *vm,
if (detach->type == VIR_DOMAIN_NET_TYPE_NETWORK) {
g_autoptr(virConnect) conn = virGetConnectNetwork();
if (conn)
virDomainNetReleaseActualDevice(conn, vm->def, detach);
virDomainNetReleaseActualDevice(conn, detach);
else
VIR_WARN("Unable to release network device '%s'", NULLSTR(detach->ifname));
}

4
src/lxc/lxc_process.c
View File

@ -221,7 +221,7 @@ static void virLXCProcessCleanup(virLXCDriver *driver,
}
if (iface->type == VIR_DOMAIN_NET_TYPE_NETWORK) {
if (conn || (conn = virGetConnectNetwork()))
virDomainNetReleaseActualDevice(conn, vm->def, iface);
virDomainNetReleaseActualDevice(conn, iface);
else
VIR_WARN("Unable to release network device '%s'", NULLSTR(iface->ifname));
}
@ -643,7 +643,7 @@ virLXCProcessSetupInterfaces(virLXCDriver *driver,
virDomainNetGetActualBridgeName(iface),
iface->ifname));
if (iface->type == VIR_DOMAIN_NET_TYPE_NETWORK && netconn)
virDomainNetReleaseActualDevice(netconn, def, iface);
virDomainNetReleaseActualDevice(netconn, iface);
}
virErrorRestore(&save_err);
}

10
src/qemu/qemu_hotplug.c
View File

@ -1440,7 +1440,7 @@ qemuDomainAttachNetDevice(virQEMUDriver *driver,
if (net->type == VIR_DOMAIN_NET_TYPE_NETWORK) {
if (conn)
virDomainNetReleaseActualDevice(conn, vm->def, net);
virDomainNetReleaseActualDevice(conn, net);
else
VIR_WARN("Unable to release network device '%s'", NULLSTR(net->ifname));
}
@ -4167,7 +4167,7 @@ qemuDomainChangeNet(virQEMUDriver *driver,
* no need to change the pointer in the hostdev structure */
if (olddev->type == VIR_DOMAIN_NET_TYPE_NETWORK) {
if (conn || (conn = virGetConnectNetwork()))
virDomainNetReleaseActualDevice(conn, vm->def, olddev);
virDomainNetReleaseActualDevice(conn, olddev);
else
VIR_WARN("Unable to release network device '%s'", NULLSTR(olddev->ifname));
}
@ -4208,7 +4208,7 @@ qemuDomainChangeNet(virQEMUDriver *driver,
* replace the entire device object.
*/
if (newdev && newdev->type == VIR_DOMAIN_NET_TYPE_NETWORK && conn)
virDomainNetReleaseActualDevice(conn, vm->def, newdev);
virDomainNetReleaseActualDevice(conn, newdev);
virErrorRestore(&save_err);
return ret;
@ -4788,7 +4788,7 @@ qemuDomainRemoveHostDevice(virQEMUDriver *driver,
if (net->type == VIR_DOMAIN_NET_TYPE_NETWORK) {
g_autoptr(virConnect) conn = virGetConnectNetwork();
if (conn)
virDomainNetReleaseActualDevice(conn, vm->def, net);
virDomainNetReleaseActualDevice(conn, net);
else
VIR_WARN("Unable to release network device '%s'", NULLSTR(net->ifname));
}
@ -4906,7 +4906,7 @@ qemuDomainRemoveNetDevice(virQEMUDriver *driver,
if (net->type == VIR_DOMAIN_NET_TYPE_NETWORK) {
g_autoptr(virConnect) conn = virGetConnectNetwork();
if (conn)
virDomainNetReleaseActualDevice(conn, vm->def, net);
virDomainNetReleaseActualDevice(conn, net);
else
VIR_WARN("Unable to release network device '%s'", NULLSTR(net->ifname));
} else if (net->type == VIR_DOMAIN_NET_TYPE_ETHERNET) {

2
src/qemu/qemu_process.c
View File

@ -8606,7 +8606,7 @@ void qemuProcessStop(virQEMUDriver *driver,
virDomainNetRemoveHostdev(def, net);
if (net->type == VIR_DOMAIN_NET_TYPE_NETWORK) {
if (conn || (conn = virGetConnectNetwork()))
virDomainNetReleaseActualDevice(conn, vm->def, net);
virDomainNetReleaseActualDevice(conn, net);
else
VIR_WARN("Unable to release network device '%s'", NULLSTR(net->ifname));
}