External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-02-22 11:22:23 +00:00
Code Issues Packages Projects Releases Wiki Activity

openvz: Check errors from virSocketAddrFormat

Browse Source 
Commit id 'a4e86390' modified the command line to allow --ipadd multiple
times; however, it did not account for the condition where a NULL is
returned which will could lead to some interesting errors with multiple
--ipadd's without parameters.

Signed-off-by: John Ferlan <jferlan@redhat.com>
This commit is contained in:
John Ferlan 2015-01-09 10:48:37 -05:00
parent 21160a7ac9
commit a267f01532
1 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/openvz/openvz_driver.c
View File

@ -910,6 +910,8 @@ openvzDomainSetNetwork(virConnectPtr conn, const char *vpsid,
/* --ipadd ip */ /* --ipadd ip */
for (i = 0; i < net->nips; i++) { for (i = 0; i < net->nips; i++) {
char *ipStr = virSocketAddrFormat(&net->ips[i]->address); char *ipStr = virSocketAddrFormat(&net->ips[i]->address);
if (!ipStr)
goto cleanup;
virCommandAddArgList(cmd, "--ipadd", ipStr, NULL); virCommandAddArgList(cmd, "--ipadd", ipStr, NULL);
VIR_FREE(ipStr); VIR_FREE(ipStr);
} }