mirror of
https://gitlab.com/libvirt/libvirt.git
synced 2024-08-26 18:41:17 +00:00
snapshot: new virDomainSnapshotGetParent API
Although a client can already obtain a snapshot's parent by dumping and parsing the xml, then doing a snapshot lookup by name, it is more efficient to get the parent in one step, which in turn will make operations that must traverse a snapshot hierarchy easier to perform. * include/libvirt/libvirt.h.in (virDomainSnapshotGetParent): Declare. * src/libvirt.c (virDomainSnapshotGetParent): New function. * src/libvirt_public.syms: Export it. * src/driver.h (virDrvDomainSnapshotGetParent): New callback.
This commit is contained in:
parent
b1746239f2
commit
a2f706de93
@ -2711,6 +2711,10 @@ int virDomainHasCurrentSnapshot(virDomainPtr domain, unsigned int flags);
|
||||
virDomainSnapshotPtr virDomainSnapshotCurrent(virDomainPtr domain,
|
||||
unsigned int flags);
|
||||
|
||||
/* Get a handle to the parent snapshot, if one exists */
|
||||
virDomainSnapshotPtr virDomainSnapshotGetParent(virDomainSnapshotPtr snapshot,
|
||||
unsigned int flags);
|
||||
|
||||
typedef enum {
|
||||
VIR_DOMAIN_SNAPSHOT_REVERT_RUNNING = 1 << 0, /* Run after revert */
|
||||
VIR_DOMAIN_SNAPSHOT_REVERT_PAUSED = 1 << 1, /* Pause after revert */
|
||||
|
@ -589,6 +589,10 @@ typedef virDomainSnapshotPtr
|
||||
typedef int
|
||||
(*virDrvDomainHasCurrentSnapshot)(virDomainPtr domain, unsigned int flags);
|
||||
|
||||
typedef virDomainSnapshotPtr
|
||||
(*virDrvDomainSnapshotGetParent)(virDomainSnapshotPtr snapshot,
|
||||
unsigned int flags);
|
||||
|
||||
typedef virDomainSnapshotPtr
|
||||
(*virDrvDomainSnapshotCurrent)(virDomainPtr domain,
|
||||
unsigned int flags);
|
||||
@ -854,6 +858,7 @@ struct _virDriver {
|
||||
virDrvDomainSnapshotListNames domainSnapshotListNames;
|
||||
virDrvDomainSnapshotLookupByName domainSnapshotLookupByName;
|
||||
virDrvDomainHasCurrentSnapshot domainHasCurrentSnapshot;
|
||||
virDrvDomainSnapshotGetParent domainSnapshotGetParent;
|
||||
virDrvDomainSnapshotCurrent domainSnapshotCurrent;
|
||||
virDrvDomainRevertToSnapshot domainRevertToSnapshot;
|
||||
virDrvDomainSnapshotDelete domainSnapshotDelete;
|
||||
|
@ -16149,6 +16149,50 @@ error:
|
||||
return NULL;
|
||||
}
|
||||
|
||||
/**
|
||||
* virDomainSnapshotGetParent:
|
||||
* @snapshot: a snapshot object
|
||||
* @flags: unused flag parameters; callers should pass 0
|
||||
*
|
||||
* Get the parent snapshot for @snapshot, if any.
|
||||
*
|
||||
* Returns a domain snapshot object or NULL in case of failure. If the
|
||||
* given snapshot is a root (no parent), then the VIR_ERR_NO_DOMAIN_SNAPSHOT
|
||||
* error is raised.
|
||||
*/
|
||||
virDomainSnapshotPtr
|
||||
virDomainSnapshotGetParent(virDomainSnapshotPtr snapshot,
|
||||
unsigned int flags)
|
||||
{
|
||||
virConnectPtr conn;
|
||||
|
||||
VIR_DEBUG("snapshot=%p, flags=%x", snapshot, flags);
|
||||
|
||||
virResetLastError();
|
||||
|
||||
if (!VIR_IS_DOMAIN_SNAPSHOT(snapshot)) {
|
||||
virLibDomainSnapshotError(VIR_ERR_INVALID_DOMAIN_SNAPSHOT,
|
||||
__FUNCTION__);
|
||||
virDispatchError(NULL);
|
||||
return NULL;
|
||||
}
|
||||
|
||||
conn = snapshot->domain->conn;
|
||||
|
||||
if (conn->driver->domainSnapshotGetParent) {
|
||||
virDomainSnapshotPtr snap;
|
||||
snap = conn->driver->domainSnapshotGetParent(snapshot, flags);
|
||||
if (!snap)
|
||||
goto error;
|
||||
return snap;
|
||||
}
|
||||
|
||||
virLibConnError(VIR_ERR_NO_SUPPORT, __FUNCTION__);
|
||||
error:
|
||||
virDispatchError(conn);
|
||||
return NULL;
|
||||
}
|
||||
|
||||
/**
|
||||
* virDomainRevertToSnapshot:
|
||||
* @snapshot: a domain snapshot object
|
||||
|
@ -489,4 +489,9 @@ LIBVIRT_0.9.5 {
|
||||
virDomainSnapshotGetName;
|
||||
} LIBVIRT_0.9.4;
|
||||
|
||||
LIBVIRT_0.9.7 {
|
||||
global:
|
||||
virDomainSnapshotGetParent;
|
||||
} LIBVIRT_0.9.5;
|
||||
|
||||
# .... define new API here using predicted next version number ....
|
||||
|
Loading…
Reference in New Issue
Block a user