External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-02-22 11:22:23 +00:00
Code Issues Packages Projects Releases Wiki Activity

prlsdkAddDomainVideoInfoCt: Remove pointless cleanup section

Browse Source 
'video' will only ever be NULL after the 'cleanup' label thus there's no
need to use 'virDomainVideoDefFree'. In fact we can fully remove the
cleanup section and 'ret' variable by returning directly from failure
points.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
This commit is contained in:
Peter Krempa 2021-08-03 15:05:59 +02:00
parent f90de01763
commit a31864e60a
1 changed files with 2 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/vz/vz_sdk.c
View File

@ -542,24 +542,19 @@ prlsdkAddDomainVideoInfoCt(virDomainDef *def,
virDomainXMLOption *xmlopt)
{
virDomainVideoDef *video = NULL;
int ret = -1;
if (def->ngraphics == 0)
return 0;
if (!(video = virDomainVideoDefNew(xmlopt)))
goto cleanup;
return -1;
video->type = VIR_DOMAIN_VIDEO_TYPE_PARALLELS;
video->vram = 0;
VIR_APPEND_ELEMENT(def->videos, def->nvideos, video);
ret = 0;
cleanup:
virDomainVideoDefFree(video);
return ret;
return 0;
}
static int