External/libvirt
1
0
Fork 0
Code

snapshot: speed up snapshot location

Browse Source 
Each snapshot lookup was iterating over the entire hash table, O(n),
instead of honing in directly on the hash key, amortized O(1).

Besides, fixing this means that virDomainSnapshotFindByName can now
be used inside another virHashForeach iteration (without this patch,
attempts to lookup a snapshot by name during a hash iteration will
fail due to nested iteration).

* src/conf/domain_conf.c (virDomainSnapshotFindByName): Simplify.
(virDomainSnapshotObjListSearchName): Delete unused function.
This commit is contained in:
Eric Blake 2011-08-24 13:38:42 -06:00
parent d4a965c6a8
commit a31d65695d
1 changed files with 4 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
src/conf/domain_conf.c
View File

@ -11637,23 +11637,11 @@ int virDomainSnapshotObjListNum(virDomainSnapshotObjListPtr snapshots)
return count;
}
static int virDomainSnapshotObjListSearchName(const void *payload,
const void *name ATTRIBUTE_UNUSED,
const void *data)
virDomainSnapshotObjPtr
virDomainSnapshotFindByName(const virDomainSnapshotObjListPtr snapshots,
const char *name)
{
virDomainSnapshotObjPtr obj = (virDomainSnapshotObjPtr)payload;
int want = 0;
if (STREQ(obj->def->name, (const char *)data))
want = 1;
return want;
}
virDomainSnapshotObjPtr virDomainSnapshotFindByName(const virDomainSnapshotObjListPtr snapshots,
const char *name)
{
return virHashSearch(snapshots->objs, virDomainSnapshotObjListSearchName, name);
return virHashLookup(snapshots->objs, name);
}
void virDomainSnapshotObjListRemove(virDomainSnapshotObjListPtr snapshots,