External/libvirt
1
0
Fork 0
Code

conf: add virDomainDiskBlockIoCheckABIStability()

Browse Source 
Add missing ABI stability check for blockio properties for disk
devices.

Signed-off-by: Kristina Hanicova <khanicov@redhat.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
This commit is contained in:
Kristina Hanicova 2023-08-24 12:57:00 +02:00 committed by Michal Privoznik
parent 148b7aa7e2
commit a3e19bf75a
1 changed files with 25 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

25
src/conf/domain_conf.c
View File

@ -19819,6 +19819,28 @@ virDomainVirtioOptionsCheckABIStability(virDomainVirtioOptions *src,
} }
static bool
virDomainDiskBlockIoCheckABIStability(virDomainDiskDef *src,
virDomainDiskDef *dst)
{
if (src->blockio.logical_block_size != dst->blockio.logical_block_size) {
virReportError(VIR_ERR_CONFIG_UNSUPPORTED,
_("Target disk logical_block_size %1$u does not match source %2$u"),
dst->blockio.logical_block_size, src->blockio.logical_block_size);
return false;
}
if (src->blockio.physical_block_size != dst->blockio.physical_block_size) {
virReportError(VIR_ERR_CONFIG_UNSUPPORTED,
_("Target disk physical_block_size %1$u does not match source %2$u"),
dst->blockio.physical_block_size, src->blockio.physical_block_size);
return false;
}
return true;
}
static bool static bool
virDomainDiskDefCheckABIStability(virDomainDiskDef *src, virDomainDiskDefCheckABIStability(virDomainDiskDef *src,
virDomainDiskDef *dst) virDomainDiskDef *dst)
@ -19902,6 +19924,9 @@ virDomainDiskDefCheckABIStability(virDomainDiskDef *src,
if (!virDomainDeviceInfoCheckABIStability(&src->info, &dst->info)) if (!virDomainDeviceInfoCheckABIStability(&src->info, &dst->info))
return false; return false;
if (!virDomainDiskBlockIoCheckABIStability(src, dst))
return false;
return true; return true;
} }