External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-02-02 09:55:18 +00:00
Code Issues Packages Projects Releases Wiki Activity

qemu: fix memory leak in virDomainGetVcpus

Browse Source 
https://bugzilla.redhat.com/show_bug.cgi?id=808979

The leak is really in virProcessInfoGetAffinity, as shown in the
valgrind output given in the above bug report - it calls CPU_ALLOC(),
but then fails to call CPU_FREE().

This leak has existed in every version of libvirt since 0.7.5.
This commit is contained in:
Laine Stump 2012-04-02 00:26:44 -04:00
parent d400b8fb18
commit a4650316d1
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/util/processinfo.c
View File

@ -1,5 +1,5 @@
/* /*
* Copyright (C) 2009-2010 Red Hat, Inc. * Copyright (C) 2009-2010, 2012 Red Hat, Inc.
* *
* This library is free software; you can redistribute it and/or * This library is free software; you can redistribute it and/or
* modify it under the terms of the GNU Lesser General Public * modify it under the terms of the GNU Lesser General Public
@ -140,6 +140,7 @@ realloc:
for (i = 0 ; i < maxcpu ; i++) for (i = 0 ; i < maxcpu ; i++)
if (CPU_ISSET_S(i, masklen, mask)) if (CPU_ISSET_S(i, masklen, mask))
VIR_USE_CPU(map, i); VIR_USE_CPU(map, i);
CPU_FREE(mask);
# else # else
/* Legacy method uses a fixed size cpu mask, only allows upto 1024 cpus */ /* Legacy method uses a fixed size cpu mask, only allows upto 1024 cpus */
cpu_set_t mask; cpu_set_t mask;