External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-02-22 11:22:23 +00:00
Code Issues Packages Projects Releases Wiki Activity

virsh: Remove bogus stat on log file

Browse Source 
Let's just open the file right away and deal with errors. Moreover,
there's no reason to forbid logging to, e.g., a pipe.

Signed-off-by: Jiri Denemark <jdenemar@redhat.com>
This commit is contained in:
Jiri Denemark 2014-06-24 10:50:10 +02:00
parent ca3d9afeb1
commit a4743860f8
1 changed files with 0 additions and 20 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
tools/virsh.c
View File

@ -2794,29 +2794,9 @@ vshInit(vshControl *ctl)
void void
vshOpenLogFile(vshControl *ctl) vshOpenLogFile(vshControl *ctl)
{ {
struct stat st;
if (ctl->logfile == NULL) if (ctl->logfile == NULL)
return; return;
/* check log file */
if (stat(ctl->logfile, &st) == -1) {
switch (errno) {
case ENOENT:
break;
default:
vshError(ctl, "%s",
_("failed to get the log file information"));
exit(EXIT_FAILURE);
}
} else {
if (!S_ISREG(st.st_mode)) {
vshError(ctl, "%s", _("the log path is not a file"));
exit(EXIT_FAILURE);
}
}
/* log file open */
if ((ctl->log_fd = open(ctl->logfile, LOGFILE_FLAGS, FILE_MODE)) < 0) { if ((ctl->log_fd = open(ctl->logfile, LOGFILE_FLAGS, FILE_MODE)) < 0) {
vshError(ctl, "%s", vshError(ctl, "%s",
_("failed to open the log file. check the log file path")); _("failed to open the log file. check the log file path"));