From a55093ec280183ee9066a3640df4ee4cb7f6c396 Mon Sep 17 00:00:00 2001 From: Peter Krempa Date: Tue, 20 Jul 2021 10:05:06 +0200 Subject: [PATCH] qemu: Remove return value from qemuMonitorDomainDumpCompletedCallback MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Change the callback prototype and fix the callback registered in the process code. Signed-off-by: Peter Krempa Reviewed-by: Ján Tomko --- src/qemu/qemu_monitor.h | 12 ++++++------ src/qemu/qemu_process.c | 3 +-- 2 files changed, 7 insertions(+), 8 deletions(-) diff --git a/src/qemu/qemu_monitor.h b/src/qemu/qemu_monitor.h index 6806ff9552..1de39e81eb 100644 --- a/src/qemu/qemu_monitor.h +++ b/src/qemu/qemu_monitor.h @@ -303,12 +303,12 @@ struct _qemuMonitorDumpStats { unsigned long long total; /* total bytes to be written */ }; -typedef int (*qemuMonitorDomainDumpCompletedCallback)(qemuMonitor *mon, - virDomainObj *vm, - int status, - qemuMonitorDumpStats *stats, - const char *error, - void *opaque); +typedef void (*qemuMonitorDomainDumpCompletedCallback)(qemuMonitor *mon, + virDomainObj *vm, + int status, + qemuMonitorDumpStats *stats, + const char *error, + void *opaque); typedef int (*qemuMonitorDomainPRManagerStatusChangedCallback)(qemuMonitor *mon, virDomainObj *vm, diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c index 9c7aa547b5..7e4a025e35 100644 --- a/src/qemu/qemu_process.c +++ b/src/qemu/qemu_process.c @@ -1663,7 +1663,7 @@ qemuProcessHandleMigrationPass(qemuMonitor *mon G_GNUC_UNUSED, } -static int +static void qemuProcessHandleDumpCompleted(qemuMonitor *mon G_GNUC_UNUSED, virDomainObj *vm, int status, @@ -1700,7 +1700,6 @@ qemuProcessHandleDumpCompleted(qemuMonitor *mon G_GNUC_UNUSED, cleanup: virResetLastError(); virObjectUnlock(vm); - return 0; }