External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2024-12-30 17:45:23 +00:00
Code Issues Packages Projects Releases Wiki Activity

virsh: use correct sizeof when allocating cpumap

Browse Source 
Found by coverity:
Error: SIZEOF_MISMATCH (CWE-569):
    libvirt-0.10.2/tools/virsh-domain.c:4754: suspicious_sizeof: Passing
    argument "8UL /* sizeof (cpumap) */" to function
    "_vshCalloc(vshControl *, size_t, size_t, char const *, int)" and
    then casting the return value to "unsigned char *" is suspicious.

Error: SIZEOF_MISMATCH (CWE-569):
    libvirt-0.10.2/tools/virsh-domain.c:4942: suspicious_sizeof: Passing
    argument "8UL /* sizeof (cpumap) */" to function
    "_vshCalloc(vshControl *, size_t, size_t, char const *, int)" and
    then casting the return value to "unsigned char *" is suspicious.
(cherry picked from commit dc04b2a737)
This commit is contained in:
Ján Tomko 2012-11-29 11:23:06 +01:00 committed by Cole Robinson
parent e4e5a4d349
commit a565e20b08
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
tools/virsh-domain.c
View File

@ -4739,7 +4739,7 @@ cmdVcpuPin(vshControl *ctl, const vshCmd *cmd)
/* Pin mode: pinning specified vcpu to specified physical cpus*/ /* Pin mode: pinning specified vcpu to specified physical cpus*/
cpumap = vshCalloc(ctl, cpumaplen, sizeof(cpumap)); cpumap = vshCalloc(ctl, cpumaplen, sizeof(*cpumap));
/* Parse cpulist */ /* Parse cpulist */
cur = cpulist; cur = cpulist;
if (*cur == 0) { if (*cur == 0) {
@ -4927,7 +4927,7 @@ cmdEmulatorPin(vshControl *ctl, const vshCmd *cmd)
/* Pin mode: pinning emulator threads to specified physical cpus*/ /* Pin mode: pinning emulator threads to specified physical cpus*/
cpumap = vshCalloc(ctl, cpumaplen, sizeof(cpumap)); cpumap = vshCalloc(ctl, cpumaplen, sizeof(*cpumap));
/* Parse cpulist */ /* Parse cpulist */
cur = cpulist; cur = cpulist;
if (*cur == 0) { if (*cur == 0) {