From a58edc602ebfef9323d405f846cb0076bdfc8044 Mon Sep 17 00:00:00 2001 From: Roman Bogorodskiy Date: Thu, 4 Feb 2021 19:29:44 +0400 Subject: [PATCH] bhyve: drop emulator binary value check Currently, requesting domain capabilities fails when the specified emulator binary does not equal to "/usr/sbin/bhyve". As we're not using user-specified emulator anyway, drop this check to avoid showing errors for values like "bhyve" (without absolute path). Signed-off-by: Roman Bogorodskiy Reviewed-by: Michal Privoznik --- src/bhyve/bhyve_driver.c | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/src/bhyve/bhyve_driver.c b/src/bhyve/bhyve_driver.c index 78c3241293..d02dc65a9d 100644 --- a/src/bhyve/bhyve_driver.c +++ b/src/bhyve/bhyve_driver.c @@ -1645,14 +1645,8 @@ bhyveConnectGetDomainCapabilities(virConnectPtr conn, goto cleanup; } - if (emulatorbin == NULL) { + if (emulatorbin == NULL) emulatorbin = "/usr/sbin/bhyve"; - } else if (STRNEQ(emulatorbin, "/usr/sbin/bhyve")) { - virReportError(VIR_ERR_INVALID_ARG, - _("unknown emulator binary: %s"), - emulatorbin); - goto cleanup; - } if (!(caps = virBhyveDomainCapsBuild(conn->privateData, emulatorbin, machine, arch, virttype)))