External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-02-22 11:22:23 +00:00
Code Issues Packages Projects Releases Wiki Activity

qemu: Avoid memory leak in qemuMonitorJSONExtractQueryStatsSchema

Browse Source 
In a rare case when virHashAddEntry fails we would just leak the
structure we wanted to add to the hash table.

Fixes: e89acdbc3bbada2f3c1a591278bc975ddee2d5a9
Signed-off-by: Jiri Denemark <jdenemar@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
This commit is contained in:
Jiri Denemark 2022-11-02 15:52:31 +01:00
parent 6eb02a0086
commit a607baf65a
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/qemu/qemu_monitor_json.c
View File

@ -8596,7 +8596,7 @@ qemuMonitorJSONExtractQueryStatsSchema(virJSONValue *json)
virJSONValue *stat = virJSONValueArrayGet(stats, j); virJSONValue *stat = virJSONValueArrayGet(stats, j);
const char *name = NULL; const char *name = NULL;
const char *tmp = NULL; const char *tmp = NULL;
qemuMonitorQueryStatsSchemaData *data = NULL; g_autofree qemuMonitorQueryStatsSchemaData *data = NULL;
int type = -1; int type = -1;
int unit = -1; int unit = -1;
@ -8632,7 +8632,9 @@ qemuMonitorJSONExtractQueryStatsSchema(virJSONValue *json)
virJSONValueObjectGetNumberUint(stat, "bucket-size", &data->bucket_size) < 0) virJSONValueObjectGetNumberUint(stat, "bucket-size", &data->bucket_size) < 0)
data->bucket_size = 0; data->bucket_size = 0;
virHashAddEntry(schema, name, data); if (virHashAddEntry(schema, name, data) < 0)
return NULL;
data = NULL;
} }
} }