mirror of
https://gitlab.com/libvirt/libvirt.git
synced 2024-07-06 09:55:46 +00:00
bhyve: fix memory leaks in bhyvexml2argvtest
* virNetDevTapCreateInBridgePort() mock: free '*ifname' before strdupping a hardoded value to it * testCompareXMLToArgvFiles(): unref 'conn' object in cleanup * testCompareXMLToArgvHelper(): free 'ldargs' and 'dmargs' in cleanup
This commit is contained in:
parent
9b39a9dcf4
commit
a6b81d5581
@ -1,5 +1,6 @@
|
|||||||
#include <config.h>
|
#include <config.h>
|
||||||
|
|
||||||
|
#include "viralloc.h"
|
||||||
#include "virstring.h"
|
#include "virstring.h"
|
||||||
#include "virnetdev.h"
|
#include "virnetdev.h"
|
||||||
#include "virnetdevtap.h"
|
#include "virnetdevtap.h"
|
||||||
@ -29,6 +30,7 @@ int virNetDevTapCreateInBridgePort(const char *brname ATTRIBUTE_UNUSED,
|
|||||||
virNetDevVlanPtr virtVlan ATTRIBUTE_UNUSED,
|
virNetDevVlanPtr virtVlan ATTRIBUTE_UNUSED,
|
||||||
unsigned int fakeflags ATTRIBUTE_UNUSED)
|
unsigned int fakeflags ATTRIBUTE_UNUSED)
|
||||||
{
|
{
|
||||||
|
VIR_FREE(*ifname);
|
||||||
if (VIR_STRDUP(*ifname, "vnet0") < 0)
|
if (VIR_STRDUP(*ifname, "vnet0") < 0)
|
||||||
return -1;
|
return -1;
|
||||||
return 0;
|
return 0;
|
||||||
|
@ -86,6 +86,7 @@ static int testCompareXMLToArgvFiles(const char *xml,
|
|||||||
virCommandFree(cmd);
|
virCommandFree(cmd);
|
||||||
virCommandFree(ldcmd);
|
virCommandFree(ldcmd);
|
||||||
virDomainDefFree(vmdef);
|
virDomainDefFree(vmdef);
|
||||||
|
virObjectUnref(conn);
|
||||||
return ret;
|
return ret;
|
||||||
}
|
}
|
||||||
|
|
||||||
@ -117,6 +118,8 @@ testCompareXMLToArgvHelper(const void *data)
|
|||||||
cleanup:
|
cleanup:
|
||||||
VIR_FREE(xml);
|
VIR_FREE(xml);
|
||||||
VIR_FREE(args);
|
VIR_FREE(args);
|
||||||
|
VIR_FREE(ldargs);
|
||||||
|
VIR_FREE(dmargs);
|
||||||
return ret;
|
return ret;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
Loading…
Reference in New Issue
Block a user