External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-01-28 07:25:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix leak in PCI hostdev hot-unplug

Browse Source 
* src/qemu_driver.c: sync the hostdev hot-unplug code with the disk/net
  code.
This commit is contained in:
Mark McLoughlin 2009-09-17 15:32:45 +01:00
parent 8881ae1bf8
commit a70da51ff7
1 changed files with 13 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
src/qemu_driver.c
View File

@ -6206,14 +6206,20 @@ static int qemudDomainDetachHostPciDevice(virConnectPtr conn,
pciFreeDevice(conn, pci); pciFreeDevice(conn, pci);
} }
if (i != --vm->def->nhostdevs) if (vm->def->nhostdevs > 1) {
memmove(&vm->def->hostdevs[i], memmove(vm->def->hostdevs + i,
&vm->def->hostdevs[i+1], vm->def->hostdevs + i + 1,
sizeof(*vm->def->hostdevs) * (vm->def->nhostdevs-i)); sizeof(*vm->def->hostdevs) *
(vm->def->nhostdevs - (i + 1)));
vm->def->nhostdevs--;
if (VIR_REALLOC_N(vm->def->hostdevs, vm->def->nhostdevs) < 0) { if (VIR_REALLOC_N(vm->def->hostdevs, vm->def->nhostdevs) < 0) {
virReportOOMError(conn); /* ignore, harmless */
ret = -1;
} }
} else {
VIR_FREE(vm->def->hostdevs);
vm->def->nhostdevs = 0;
}
virDomainHostdevDefFree(detach);
return ret; return ret;
} }