External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-03-20 07:59:00 +00:00
Code

qemu: Avoid a possible NULL pointer deref in qemuDomainGetTLSObjects

Browse Source 
Passing a NULL value for the argument secAlias to the function
qemuDomainGetTLSObjects would cause a segmentation fault in
libvirtd.

Changed code to check before dereferencing a NULL secAlias.

Signed-off-by: Ashish Mittal <ashmit602@gmail.com>
This commit is contained in:
Ashish Mittal 2017-09-20 05:32:29 -07:00 committed by John Ferlan
parent 0c81518b2d
commit a74a16320b
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/qemu/qemu_hotplug.c
View File

@ -1638,12 +1638,14 @@ qemuDomainGetTLSObjects(virQEMUCapsPtr qemuCaps,
if (qemuBuildSecretInfoProps(secinfo, secProps) < 0) if (qemuBuildSecretInfoProps(secinfo, secProps) < 0)
return -1; return -1;
if (!(*secAlias = qemuDomainGetSecretAESAlias(srcAlias, false))) if (!secAlias ||
!(*secAlias = qemuDomainGetSecretAESAlias(srcAlias, false)))
return -1; return -1;
} }
if (qemuBuildTLSx509BackendProps(tlsCertdir, tlsListen, tlsVerify, if (qemuBuildTLSx509BackendProps(tlsCertdir, tlsListen, tlsVerify,
*secAlias, qemuCaps, tlsProps) < 0) secAlias ? *secAlias : NULL, qemuCaps,
tlsProps) < 0)
return -1; return -1;
if (!(*tlsAlias = qemuAliasTLSObjFromSrcAlias(srcAlias))) if (!(*tlsAlias = qemuAliasTLSObjFromSrcAlias(srcAlias)))