External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-03-07 17:28:15 +00:00
Code

virDomainCapsEnumFormat: Switch to virXMLFormatElement()

Browse Source 
We are formatting <enum/> element and its children using
virBufferAddLit(), virBufferAsprintf(), virBufferAdjustIndent(),
etc. Well, we can avoid that when switching to
virXMLFormatElement().

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Reviewed-by: Peter Krempa <pkrempa@redhat.com>
This commit is contained in:
Michal Privoznik 2023-01-05 08:31:27 +01:00
parent 78b3400e50
commit a7789d9324
1 changed files with 5 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
src/conf/domain_capabilities.c
View File

@ -269,18 +269,14 @@ virDomainCapsEnumFormat(virBuffer *buf,
const char *capsEnumName, const char *capsEnumName,
virDomainCapsValToStr valToStr) virDomainCapsValToStr valToStr)
{ {
g_auto(virBuffer) attrBuf = VIR_BUFFER_INITIALIZER;
g_auto(virBuffer) childBuf = VIR_BUFFER_INIT_CHILD(buf);
size_t i; size_t i;
if (!capsEnum->report) if (!capsEnum->report)
return 0; return 0;
virBufferAsprintf(buf, "<enum name='%s'", capsEnumName); virBufferAsprintf(&attrBuf, " name='%s'", capsEnumName);
if (!capsEnum->values) {
virBufferAddLit(buf, "/>\n");
return 0;
}
virBufferAddLit(buf, ">\n");
virBufferAdjustIndent(buf, 2);
for (i = 0; i < sizeof(capsEnum->values) * CHAR_BIT; i++) { for (i = 0; i < sizeof(capsEnum->values) * CHAR_BIT; i++) {
const char *val; const char *val;
@ -289,11 +285,10 @@ virDomainCapsEnumFormat(virBuffer *buf,
continue; continue;
if ((val = (valToStr)(i))) if ((val = (valToStr)(i)))
virBufferAsprintf(buf, "<value>%s</value>\n", val); virBufferAsprintf(&childBuf, "<value>%s</value>\n", val);
} }
virBufferAdjustIndent(buf, -2);
virBufferAddLit(buf, "</enum>\n");
virXMLFormatElement(buf, "enum", &attrBuf, &childBuf);
return 0; return 0;
} }