mirror of
https://gitlab.com/libvirt/libvirt.git
synced 2024-10-05 22:05:47 +00:00
qemu: Fix NULL pointer access in qemuProcessInitCpuAffinity()
Commit 2f2254c7f4
attempted to fix a memory leak by ensuring
cpumapToSet is always a freshly allocated bitmap, but regrettably
introduced a NULL pointer access while doing so, because it called
virBitmapCopy() without allocating the destination bitmap first.
Solve the issue by using virBitmapNewCopy() instead.
Reported-by: John Ferlan <jferlan@redhat.com>
Signed-off-by: Andrea Bolognani <abologna@redhat.com>
Reviewed-by: Erik Skultety <eskultet@redhat.com>
Reviewed-by: John Ferlan <jferlan@redhat.com>
This commit is contained in:
parent
01628f4b44
commit
a84922c09e
@ -2498,7 +2498,7 @@ qemuProcessInitCpuAffinity(virDomainObjPtr vm)
|
||||
if (virNumaNodesetToCPUset(nodeset, &cpumapToSet) < 0)
|
||||
return -1;
|
||||
} else if (vm->def->cputune.emulatorpin) {
|
||||
if (virBitmapCopy(cpumapToSet, vm->def->cputune.emulatorpin) < 0)
|
||||
if (!(cpumapToSet = virBitmapNewCopy(vm->def->cputune.emulatorpin)))
|
||||
return -1;
|
||||
} else {
|
||||
if (qemuProcessGetAllCpuAffinity(&cpumapToSet) < 0)
|
||||
|
Loading…
Reference in New Issue
Block a user