From a8c983d0fa1ba915f7a75deeceb20da1c88fd1db Mon Sep 17 00:00:00 2001 From: Michal Privoznik Date: Wed, 24 May 2023 10:53:03 +0200 Subject: [PATCH] docs: Clarify values reported by virDomainMemoryStats() I was approached by a KubeVirt developer to clarify what value does VIR_DOMAIN_MEMORY_STAT_DISK_CACHES report, whether it's from the guest or the host POV. And since I didn't know the answer even after reading the docs I think we can do better. Clarify the POV then. Signed-off-by: Michal Privoznik Reviewed-by: Peter Krempa --- include/libvirt/libvirt-domain.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/include/libvirt/libvirt-domain.h b/include/libvirt/libvirt-domain.h index 3312b8339e..20467849a4 100644 --- a/include/libvirt/libvirt-domain.h +++ b/include/libvirt/libvirt-domain.h @@ -709,7 +709,8 @@ typedef virDomainInterfaceStatsStruct *virDomainInterfaceStatsPtr; /** * virDomainMemoryStatTags: * - * Memory Statistics Tags: + * These represent values from inside of the guest (e.g. the same value would + * be read from '/proc/meminfo' and/or other files from inside the guest). * * Since: 0.7.5 */