External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-01-18 10:35:20 +00:00
Code Issues Packages Projects Releases Wiki Activity

tests: add warning that qemucapsprobe prefers native host/guest arch

Browse Source 
Generally we want the QEMU capabilities data in git to report KVM
related features, and thus we strongly prefer that the capabilities are
generated on a native host.

Reviewed-by: Andrea Bolognani <abologna@redhat.com>
Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
This commit is contained in:
Daniel P. Berrangé 2021-04-06 12:00:00 +01:00
parent 713ad30004
commit a8c9b49747
1 changed files with 14 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
tests/qemucapsprobe.c
View File

@ -46,6 +46,8 @@ main(int argc, char **argv)
{
virThread thread;
virQEMUCapsPtr caps;
virArch host;
virArch guest;
const char *mock = VIR_TEST_MOCK("qemucapsprobe");
if (!virFileIsExecutable(mock)) {
@ -80,6 +82,18 @@ main(int argc, char **argv)
-1, -1, NULL, 0, NULL)))
return EXIT_FAILURE;
host = virArchFromHost();
guest = virQEMUCapsGetArch(caps);
if (host != guest) {
fprintf(stderr,
"WARNING: guest architecture '%s' does not match host '%s'.\n"
"WARNING: When generating capabilities for the libvirt test\n"
"WARNING: suite, it is strongly desired to generate capabilities\n"
"WARNING: on the native host to capture KVM related features.\n",
virArchToString(guest), virArchToString(host));
}
virObjectUnref(caps);
return EXIT_SUCCESS;