External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-02-22 11:22:23 +00:00
Code Issues Packages Projects Releases Wiki Activity

qemu: saveimage: only steal domXML on success

Browse Source 
The comment and the caller assume virQEMUSaveDataNew only steals
domXML on success, but it is copied even on failure.

Also remove the misleading g_steal_pointer call on a local variable.

Reported by coverity.

Signed-off-by: Ján Tomko <jtomko@redhat.com>
Reviewed-by: Erik Skultety <eskultet@redhat.com>
This commit is contained in:
Ján Tomko 2021-02-18 14:16:36 +01:00
parent f4943d3c18
commit a8ed27e70a
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/qemu/qemu_saveimage.c
View File

@ -105,8 +105,6 @@ virQEMUSaveDataNew(char *domXML,
data = g_new0(virQEMUSaveData, 1);
data->xml = g_steal_pointer(&domXML);
if (cookieObj &&
!(data->cookie = virSaveCookieFormat((virObjectPtr) cookieObj,
virDomainXMLOptionGetSaveCookie(xmlopt))))
@ -118,6 +116,7 @@ virQEMUSaveDataNew(char *domXML,
header->was_running = running ? 1 : 0;
header->compressed = compressed;
data->xml = domXML;
return data;
error: