From a93eb09a971f191e0ee91a8611ac976d71077987 Mon Sep 17 00:00:00 2001 From: "Daniel P. Berrange" Date: Wed, 25 Sep 2013 15:36:39 +0100 Subject: [PATCH] Avoid crash on OOM in virnetmessagetest The virnetmessagetest code did not check for failure to allocate the message object. This lead to a crash on OOM in the test suite. Signed-off-by: Daniel P. Berrange --- tests/virnetmessagetest.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/tests/virnetmessagetest.c b/tests/virnetmessagetest.c index 1aa4c25a66..3c9bead5d3 100644 --- a/tests/virnetmessagetest.c +++ b/tests/virnetmessagetest.c @@ -327,6 +327,9 @@ static int testMessagePayloadDecode(const void *args ATTRIBUTE_UNUSED) }; int ret = -1; + if (!msg) + return -1; + msg->bufferLength = 4; if (VIR_ALLOC_N(msg->buffer, msg->bufferLength) < 0) goto cleanup; @@ -476,6 +479,9 @@ static int testMessagePayloadStreamEncode(const void *args ATTRIBUTE_UNUSED) }; int ret = -1; + if (!msg) + return -1; + msg->header.prog = 0x11223344; msg->header.vers = 0x01; msg->header.proc = 0x666;