External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-02-08 12:41:29 +00:00
Code Issues Packages Projects Releases Wiki Activity

conf: checkpoint: Add a flag storing whether disk 'size' is valid

Browse Source 
Avoid printing '0' size in case when we weren't able to determine the
backup size by adding a flag whether the size is valid and interlock
printing of the field according to the flag.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
This commit is contained in:
Peter Krempa 2020-07-01 16:58:29 +02:00
parent 459a60823e
commit a94997c476
3 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/conf/checkpoint_conf.c
View File

@ -430,7 +430,7 @@ virDomainCheckpointDiskDefFormat(virBufferPtr buf,
virDomainCheckpointTypeToString(disk->type)); virDomainCheckpointTypeToString(disk->type));
if (disk->bitmap) { if (disk->bitmap) {
virBufferEscapeString(buf, " bitmap='%s'", disk->bitmap); virBufferEscapeString(buf, " bitmap='%s'", disk->bitmap);
if (flags & VIR_DOMAIN_CHECKPOINT_FORMAT_SIZE) if (flags & VIR_DOMAIN_CHECKPOINT_FORMAT_SIZE && disk->sizeValid)
virBufferAsprintf(buf, " size='%llu'", disk->size); virBufferAsprintf(buf, " size='%llu'", disk->size);
} }
virBufferAddLit(buf, "/>\n"); virBufferAddLit(buf, "/>\n");

1
src/conf/checkpoint_conf.h
View File

@ -46,6 +46,7 @@ struct _virDomainCheckpointDiskDef {
int type; /* virDomainCheckpointType */ int type; /* virDomainCheckpointType */
char *bitmap; /* bitmap name, if type is bitmap */ char *bitmap; /* bitmap name, if type is bitmap */
unsigned long long size; /* current checkpoint size in bytes */ unsigned long long size; /* current checkpoint size in bytes */
bool sizeValid;
}; };
/* Stores the complete checkpoint metadata */ /* Stores the complete checkpoint metadata */

1
tests/qemudomaincheckpointxml2xmltest.c
View File

@ -83,6 +83,7 @@ testCompareXMLToXMLFiles(const char *inxml,
} }
if (flags & TEST_SIZE) { if (flags & TEST_SIZE) {
def->disks[0].size = 1048576; def->disks[0].size = 1048576;
def->disks[0].sizeValid = true;
formatflags |= VIR_DOMAIN_CHECKPOINT_FORMAT_SIZE; formatflags |= VIR_DOMAIN_CHECKPOINT_FORMAT_SIZE;
} }