External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-03-20 07:59:00 +00:00
Code

virDomainObjListAddLocked: Drop useless @cleanup label

Browse Source 
It's a premature optimization. It's perfectly acceptable for
'error' label to deal with @vm == NULL case.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Reviewed-by: Nikolay Shirokovskiy <nshirokovskiy@virtuozzo.com>
This commit is contained in:
Michal Privoznik 2019-05-28 15:47:12 +02:00
parent 08ad83eee1
commit a95b67bec3
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/conf/virdomainobjlist.c
View File

@ -332,7 +332,7 @@ virDomainObjListAddLocked(virDomainObjListPtr doms,
} }
if (!(vm = virDomainObjNew(xmlopt))) if (!(vm = virDomainObjNew(xmlopt)))
goto cleanup; goto error;
vm->def = def; vm->def = def;
if (virDomainObjListAddObjLocked(doms, vm) < 0) { if (virDomainObjListAddObjLocked(doms, vm) < 0) {
@ -340,7 +340,7 @@ virDomainObjListAddLocked(virDomainObjListPtr doms,
goto error; goto error;
} }
} }
cleanup:
return vm; return vm;
error: error: