External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-01-20 19:45:22 +00:00
Code Issues Packages Projects Releases Wiki Activity

virresctrl: Fix updating the mask for a cache resource

Browse Source 
In 'virResctrlAllocUpdateMask', mask is updated only if 'previous mask' is NULL.

By default, the bitmask for a cache resource for a VM is initialized with
'default-resctrl-group' bitmask. So the 'previous mask' would not be NULL and
mask won't get updated if cachetune is configured for a VM. This causes libvirt
to use same bitmask as 'default-resctrl-group' bitmask for a cache resource for
a VM. This patch fixes the issue.

Fixes: d8a354954aba9cd45ab0317915a0a2be27c04767

Signed-off-by: Vinayak Kale <vkale@nvidia.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
Reviewed-by: Daniel Henrique Barboza <danielhb413@gmail.com>
Signed-off-by: Ján Tomko <jtomko@redhat.com>
This commit is contained in:
Vinayak Kale 2021-07-02 12:53:15 +05:30 committed by Ján Tomko
parent 6bda1eb157
commit a9c7da6126
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/util/virresctrl.c
View File

@ -1104,8 +1104,10 @@ virResctrlAllocUpdateMask(virResctrlAlloc *alloc,
VIR_EXPAND_N(a_type->masks, a_type->nmasks, VIR_EXPAND_N(a_type->masks, a_type->nmasks,
cache - a_type->nmasks + 1); cache - a_type->nmasks + 1);
if (!a_type->masks[cache]) if (a_type->masks[cache])
a_type->masks[cache] = virBitmapNewCopy(mask); virBitmapFree(a_type->masks[cache]);
a_type->masks[cache] = virBitmapNewCopy(mask);
return 0; return 0;
} }