External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-04-26 15:14:42 +00:00
Code

fix missing authentication on virsh shell commands

Browse Source 
* src/virsh.c: fix missing authentication when command are issued
  from the shell, patch by Matthias Bolte
Daniel
This commit is contained in:
Daniel Veillard 2009-03-23 16:36:32 +00:00
parent de4950b200
commit aac6018a35
2 changed files with 9 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
ChangeLog
View File

@ -1,3 +1,8 @@
Mon Mar 23 17:33:17 CET 2009 Daniel Veillard <veillard@redhat.com>
* src/virsh.c: fix missing authentication when command are issued
from the shell, patch by Matthias Bolte
Fri Mar 20 21:43:57 CET 2009 Daniel Veillard <veillard@redhat.com> Fri Mar 20 21:43:57 CET 2009 Daniel Veillard <veillard@redhat.com>
* src/util.c: flag unused parameters, by Maximilian Wilhelm * src/util.c: flag unused parameters, by Maximilian Wilhelm

7
src/virsh.c
View File

@ -468,13 +468,14 @@ cmdConnect(vshControl *ctl, const vshCmd *cmd)
ctl->name = vshStrdup(ctl, vshCommandOptString(cmd, "name", NULL)); ctl->name = vshStrdup(ctl, vshCommandOptString(cmd, "name", NULL));
if (!ro) { if (!ro) {
ctl->conn = virConnectOpen(ctl->name);
ctl->readonly = 0; ctl->readonly = 0;
} else { } else {
ctl->conn = virConnectOpenReadOnly(ctl->name);
ctl->readonly = 1; ctl->readonly = 1;
} }
ctl->conn = virConnectOpenAuth(ctl->name, virConnectAuthPtrDefault,
ctl->readonly ? VIR_CONNECT_RO : 0);
if (!ctl->conn) if (!ctl->conn)
vshError(ctl, FALSE, "%s", _("Failed to connect to the hypervisor")); vshError(ctl, FALSE, "%s", _("Failed to connect to the hypervisor"));
@ -2315,7 +2316,7 @@ cmdMigrate (vshControl *ctl, const vshCmd *cmd)
flags |= VIR_MIGRATE_LIVE; flags |= VIR_MIGRATE_LIVE;
/* Temporarily connect to the destination host. */ /* Temporarily connect to the destination host. */
dconn = virConnectOpen (desturi); dconn = virConnectOpenAuth (desturi, virConnectAuthPtrDefault, 0);
if (!dconn) goto done; if (!dconn) goto done;
/* Migrate. */ /* Migrate. */