External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-01-06 21:15:22 +00:00
Code Issues Packages Projects Releases Wiki Activity

qemu: fix resource leak

Browse Source 
Error: RESOURCE_LEAK:
/libvirt/src/qemu/qemu_driver.c:6968:
alloc_fn: Calling allocation function "calloc".
/libvirt/src/qemu/qemu_driver.c:6968:
var_assign: Assigning: "nodeset" =  storage returned from "calloc(1UL, 1UL)".
/libvirt/src/qemu/qemu_driver.c:6977:
noescape: Variable "nodeset" is not freed or pointed-to in function "virTypedParameterAssign".
/libvirt/src/qemu/qemu_driver.c:6997:
leaked_storage: Variable "nodeset" going out of scope leaks the storage it points to.

(cherry picked from commit c0774482ff)
This commit is contained in:
Stefan Berger 2012-05-04 10:42:09 -04:00 committed by Cole Robinson
parent 052ef069b1
commit ab26f4e372
1 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/qemu/qemu_driver.c
View File

@ -6973,6 +6973,9 @@ qemuDomainGetNumaParameters(virDomainPtr dom,
if (virTypedParameterAssign(param, VIR_DOMAIN_NUMA_NODESET, if (virTypedParameterAssign(param, VIR_DOMAIN_NUMA_NODESET,
VIR_TYPED_PARAM_STRING, nodeset) < 0) VIR_TYPED_PARAM_STRING, nodeset) < 0)
goto cleanup; goto cleanup;
nodeset = NULL;
break; break;
default: default:
@ -6986,6 +6989,7 @@ qemuDomainGetNumaParameters(virDomainPtr dom,
ret = 0; ret = 0;
cleanup: cleanup:
VIR_FREE(nodeset);
virCgroupFree(&group); virCgroupFree(&group);
if (vm) if (vm)
virDomainObjUnlock(vm); virDomainObjUnlock(vm);