External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2024-12-22 21:55:25 +00:00
Code Issues Packages Projects Releases Wiki Activity

Avoid Coverity DEADCODE warning

Browse Source 
Commit '922b7fda' resulted in two DEADCODE warnings from Coverity in
remoteDispatchAuthPolkit and virAccessDriverPolkitFormatProcess.
Commit '604ae657' modified the daemon.c code to remove the deadcode
issue, but did not do so for viracessdriverpolkit.c. This just mimics
the same changes
This commit is contained in:
John Ferlan 2013-10-18 06:43:47 -04:00
parent f919cf6917
commit ab479c9038
1 changed files with 12 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

25
src/access/viraccessdriverpolkit.c
View File

@ -76,8 +76,9 @@ virAccessDriverPolkitFormatProcess(const char *actionid)
const char *callerTime = NULL;
const char *callerUid = NULL;
char *ret = NULL;
bool supportsuid = false;
#ifndef PKCHECK_SUPPORTS_UID
static bool polkitInsecureWarned;
#endif
if (!identity) {
virAccessError(VIR_ERR_ACCESS_DENIED,
@ -109,19 +110,17 @@ virAccessDriverPolkitFormatProcess(const char *actionid)
}
#ifdef PKCHECK_SUPPORTS_UID
supportsuid = true;
#endif
if (supportsuid) {
if (virAsprintf(&ret, "%s,%s,%s", callerPid, callerTime, callerUid) < 0)
goto cleanup;
} else {
if (!polkitInsecureWarned) {
VIR_WARN("No support for caller UID with pkcheck. This deployment is known to be insecure.");
polkitInsecureWarned = true;
}
if (virAsprintf(&ret, "%s,%s", callerPid, callerTime) < 0)
goto cleanup;
if (virAsprintf(&ret, "%s,%s,%s", callerPid, callerTime, callerUid) < 0)
goto cleanup;
#else
if (!polkitInsecureWarned) {
VIR_WARN("No support for caller UID with pkcheck. "
"This deployment is known to be insecure.");
polkitInsecureWarned = true;
}
if (virAsprintf(&ret, "%s,%s", callerPid, callerTime) < 0)
goto cleanup;
#endif
cleanup:
virObjectUnref(identity);