External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-02-22 11:22:23 +00:00
Code Issues Packages Projects Releases Wiki Activity

qemuMigrationSrcBeginPhaseBlockDirtyBitmaps: Use qemuMigrationAnyCopyDisk()

Browse Source 
The function open-coded the checking whether a disk is being migrated
with non-shared storage and did so badly (not taking into account if
user doesn't explicitly provide list of disks to migrate).

Use the existing helper instead.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Pavel Hrdina <phrdina@redhat.com>
This commit is contained in:
Peter Krempa 2024-09-27 13:33:40 +02:00
parent 9bf319147c
commit ab52a069ee
1 changed files with 2 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
src/qemu/qemu_migration.c
View File

@ -2466,19 +2466,8 @@ qemuMigrationSrcBeginPhaseBlockDirtyBitmaps(qemuMigrationCookie *mig,
if (!nodedata) if (!nodedata)
continue; continue;
if (migrate_disks) { if (!qemuMigrationAnyCopyDisk(diskdef, nmigrate_disks, migrate_disks))
bool migrating = false; continue;
for (j = 0; j < nmigrate_disks; j++) {
if (STREQ(migrate_disks[j], diskdef->dst)) {
migrating = true;
break;
}
}
if (!migrating)
continue;
}
for (j = 0; j < nodedata->nbitmaps; j++) { for (j = 0; j < nodedata->nbitmaps; j++) {
qemuMigrationBlockDirtyBitmapsDiskBitmap *bitmap; qemuMigrationBlockDirtyBitmapsDiskBitmap *bitmap;