External/libvirt
1
0
Fork 0
Code

Fix use-after-free in handling domain taint flags

Browse Source 
* src/conf/domain_conf.c: Fix use after free
This commit is contained in:
Daniel P. Berrange 2011-06-22 17:33:10 +01:00
parent caf808c790
commit abb82f53ed
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/conf/domain_conf.c
View File

@ -6731,12 +6731,13 @@ static virDomainObjPtr virDomainObjParseXML(virCapsPtr caps,
char *str = virXMLPropString(nodes[i], "flag"); char *str = virXMLPropString(nodes[i], "flag");
if (str) { if (str) {
int flag = virDomainTaintTypeFromString(str); int flag = virDomainTaintTypeFromString(str);
VIR_FREE(str);
if (flag < 0) { if (flag < 0) {
virDomainReportError(VIR_ERR_INTERNAL_ERROR, virDomainReportError(VIR_ERR_INTERNAL_ERROR,
_("Unknown taint flag %s"), str); _("Unknown taint flag %s"), str);
VIR_FREE(str);
goto error; goto error;
} }
VIR_FREE(str);
virDomainObjTaint(obj, flag); virDomainObjTaint(obj, flag);
} }
} }