External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2024-10-22 14:09:22 +00:00
Code Issues Packages Projects Releases Wiki Activity

vbox: Resolve Coverity UNUSED_VALUE

Browse Source 
Handle a few places where Coverity complains about the value being
unused. For two of them (Close cases) - the comments above the close
indicate there is no harm to ignore the error - so added an ignore_value.
For the other condition, added an rc check like other callers.

Signed-off-by: John Ferlan <jferlan@redhat.com>
This commit is contained in:
John Ferlan 2014-09-04 09:56:06 -04:00
parent 8ea809df15
commit abddeb8434
1 changed files with 7 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/vbox/vbox_common.c
View File

@ -4345,6 +4345,11 @@ static int vboxCloseDisksRecursively(virDomainPtr dom, char *location)
PRUnichar *childLocationUtf = NULL; PRUnichar *childLocationUtf = NULL;
char *childLocation = NULL; char *childLocation = NULL;
rc = gVBoxAPI.UIMedium.GetLocation(childMedium, &childLocationUtf); rc = gVBoxAPI.UIMedium.GetLocation(childMedium, &childLocationUtf);
if (NS_FAILED(rc)) {
virReportError(VIR_ERR_INTERNAL_ERROR, "%s",
_("Unable to get childMedium location"));
goto cleanup;
}
VBOX_UTF16_TO_UTF8(childLocationUtf, &childLocation); VBOX_UTF16_TO_UTF8(childLocationUtf, &childLocation);
VBOX_UTF16_FREE(childLocationUtf); VBOX_UTF16_FREE(childLocationUtf);
if (vboxCloseDisksRecursively(dom, childLocation) < 0) { if (vboxCloseDisksRecursively(dom, childLocation) < 0) {
@ -4767,7 +4772,7 @@ vboxSnapshotRedefine(virDomainPtr dom,
* succeed, unless there is still another machine which uses the * succeed, unless there is still another machine which uses the
* medium. No harm done if we ignore the error. * medium. No harm done if we ignore the error.
*/ */
rc = gVBoxAPI.UIMedium.Close(medium); ignore_value(gVBoxAPI.UIMedium.Close(medium));
} }
VBOX_UTF8_FREE(locationUtf8); VBOX_UTF8_FREE(locationUtf8);
} }
@ -6987,7 +6992,7 @@ vboxDomainSnapshotDeleteMetadataOnly(virDomainSnapshotPtr snapshot)
* reference in a sane order, which means that closing will normally * reference in a sane order, which means that closing will normally
* succeed, unless there is still another machine which uses the * succeed, unless there is still another machine which uses the
* medium. No harm done if we ignore the error. */ * medium. No harm done if we ignore the error. */
rc = gVBoxAPI.UIMedium.Close(medium); ignore_value(gVBoxAPI.UIMedium.Close(medium));
} }
VBOX_UTF16_FREE(locationUtf16); VBOX_UTF16_FREE(locationUtf16);
VBOX_UTF8_FREE(locationUtf8); VBOX_UTF8_FREE(locationUtf8);