From ac1a9a5e8b4a146dd5bd520e8baaf2f4a9d40e4a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?J=C3=A1n=20Tomko?= Date: Fri, 3 Sep 2021 20:16:15 +0200 Subject: [PATCH] tests: esxutils: reduce variable scope in testEscapeDatastoreItem MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Also use g_auto. Signed-off-by: Ján Tomko Reviewed-by: Pavel Hrdina --- tests/esxutilstest.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/tests/esxutilstest.c b/tests/esxutilstest.c index bfb35fa356..d537da3011 100644 --- a/tests/esxutilstest.c +++ b/tests/esxutilstest.c @@ -161,23 +161,19 @@ static int testEscapeDatastoreItem(const void *data G_GNUC_UNUSED) { size_t i; - char *escaped = NULL; for (i = 0; i < G_N_ELEMENTS(datastoreItems); ++i) { - VIR_FREE(escaped); + g_autofree char *escaped = NULL; escaped = esxUtil_EscapeDatastoreItem(datastoreItems[i].string); if (escaped == NULL) return -1; - if (STRNEQ(datastoreItems[i].escaped, escaped)) { - VIR_FREE(escaped); + if (STRNEQ(datastoreItems[i].escaped, escaped)) return -1; - } } - VIR_FREE(escaped); return 0; }