External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2025-02-03 18:35:19 +00:00
Code Issues Packages Projects Releases Wiki Activity

xenapi: Resolve Coverity REVERSE_INULL

Browse Source 
Coverity notes in xenapiDomainGetXMLDesc that 'vms' is dereferenced
a few times before a "if (vms) xen_vm_set_free(vms);" call is made.
Since we'd exit out much sooner if the fetch of the vms failed, just
remove the unnecessary "if (vms)" check.

(cherry picked from commit eab968c7d7b4ee94e504499dc2a4ea70643718a0)
This commit is contained in:
John Ferlan 2015-03-10 19:14:31 -04:00 committed by Cole Robinson
parent 2cb4b820fd
commit ac4713899b
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/xenapi/xenapi_driver.c
View File

@ -1563,8 +1563,7 @@ xenapiDomainGetXMLDesc(virDomainPtr dom, unsigned int flags)
}
xen_vif_set_free(vif_set);
}
if (vms)
xen_vm_set_free(vms);
xen_vm_set_free(vms);
xml = virDomainDefFormat(defPtr, flags);
virDomainDefFree(defPtr);
return xml;