From ac5a58dad6163c21356055ba3a163f842167ea97 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Fabiano=20Fid=C3=AAncio?= Date: Thu, 19 Dec 2019 10:39:32 +0100 Subject: [PATCH] interface: Don't check the output of virGetUserRuntimeDirectory() MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit virGetUserRuntimeDirectory() *never* *ever* returns NULL, making the checks for it completely unnecessary. Signed-off-by: Fabiano Fidêncio Reviewed-by: Ján Tomko --- src/interface/interface_backend_netcf.c | 3 +-- src/interface/interface_backend_udev.c | 3 +-- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/src/interface/interface_backend_netcf.c b/src/interface/interface_backend_netcf.c index 4f46717cf3..65cb7eae62 100644 --- a/src/interface/interface_backend_netcf.c +++ b/src/interface/interface_backend_netcf.c @@ -105,8 +105,7 @@ netcfStateInitialize(bool privileged, } else { g_autofree char *rundir = NULL; - if (!(rundir = virGetUserRuntimeDirectory())) - goto error; + rundir = virGetUserRuntimeDirectory(); driver->stateDir = g_strdup_printf("%s/interface/run", rundir); } diff --git a/src/interface/interface_backend_udev.c b/src/interface/interface_backend_udev.c index 26b1045f8a..7cc098eb33 100644 --- a/src/interface/interface_backend_udev.c +++ b/src/interface/interface_backend_udev.c @@ -1160,8 +1160,7 @@ udevStateInitialize(bool privileged, } else { g_autofree char *rundir = NULL; - if (!(rundir = virGetUserRuntimeDirectory())) - goto cleanup; + rundir = virGetUserRuntimeDirectory(); driver->stateDir = g_strdup_printf("%s/interface/run", rundir); }