External/libvirt
1
0
Fork 0
mirror of https://gitlab.com/libvirt/libvirt.git synced 2024-10-29 17:33:09 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix FS volume creation with backing stores.

Browse Source 
This regressed when CreateXMLFrom was added: we should only perform the
backing store comparison if an input volume was passed.
This commit is contained in:
Cole Robinson 2009-06-16 15:47:53 +00:00
parent 53603043c7
commit ac75bd1b1e
2 changed files with 7 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
ChangeLog
View File

@ -1,3 +1,7 @@
Tue Jun 16 11:43:17 EDT 2009 Cole Robinson <crobinso@redhat.com>
* src/storage_backend_fs.c: Fix FS volume creation with backing stores.
Tue Jun 16 11:33:54 EDT 2009 Cole Robinson <crobinso@redhat.com> Tue Jun 16 11:33:54 EDT 2009 Cole Robinson <crobinso@redhat.com>
* src/domain_conf.c src/domain_conf.h src/libvirt_private.syms * src/domain_conf.c src/domain_conf.h src/libvirt_private.syms

5
src/storage_backend_fs.c
View File

@ -1251,8 +1251,9 @@ static int createQemuImg(virConnectPtr conn,
* backing store, not really sure what use it serves though, and it * backing store, not really sure what use it serves though, and it
* may cause issues with lvm. Untested essentially. * may cause issues with lvm. Untested essentially.
*/ */
if (!inputBackingPath || if (inputvol &&
!STREQ(inputBackingPath, vol->backingStore.path)) { (!inputBackingPath ||
STRNEQ(inputBackingPath, vol->backingStore.path))) {
virStorageReportError(conn, VIR_ERR_INTERNAL_ERROR, virStorageReportError(conn, VIR_ERR_INTERNAL_ERROR,
"%s", _("a different backing store can not " "%s", _("a different backing store can not "
"be specified.")); "be specified."));